-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a monomorphic and monofunctorial distage-example variants #447
Make a monomorphic and monofunctorial distage-example variants #447
Conversation
There are two issues with this P/R:
I would suggest the following:
|
Yep, I see. About replacing code - I initially thought to do it as Kai suggested in the original issue. To make PR here and then put it another repository, but separate directories sound good as well. To clarify: they also have to be in separate sbt modules? |
Yep, I think so. |
a988474
to
0e28225
Compare
Sorry for enormous lines of code changes. They are caused by moving and copying src/main/resources/META-INF.native-image/docker-java. Also, I had problems with launching GraalVM build locally, so did not actually check that commands from CI work as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! 🙏 There are a still a few small issues left before merging, though
distage-example-monofunctor-tf/src/main/scala/leaderboard/LeaderboardRole.scala
Outdated
Show resolved
Hide resolved
distage-example-monomorphic-cats/src/test/scala/leaderboard/tests.scala
Outdated
Show resolved
Hide resolved
distage-example-monomorphic-cats/src/main/scala/leaderboard/sql/SQL.scala
Outdated
Show resolved
Hide resolved
distage-example-monomorphic-cats/src/main/scala/leaderboard/repo/Ladder.scala
Outdated
Show resolved
Hide resolved
...xample-monofunctor-tf/src/main/resources/META-INF/native-image/auto-cold/reflect-config.json
Outdated
Show resolved
Hide resolved
distage-example-monofunctor-tf/src/test/scala/leaderboard/tests.scala
Outdated
Show resolved
Hide resolved
distage-example-monofunctor-tf/src/main/scala/leaderboard/LeaderboardRole.scala
Outdated
Show resolved
Hide resolved
Thanks for your time! Fixed most of the minor issues. |
@Ivoyaa Yeah, check native image step only for bifunctor. |
@neko-kai @pshirshov hi! Fixed the CI step, can you, please, launch it again? upd: oh, its automatic |
@pshirshov @neko-kai hi! Can you review this PR again, please? 👀 |
@Ivoyaa Thank you! Sorry for the wait for merging 🙏 |
An attempt to implement 7mind/izumi#1525